[dpdk-dev] [PATCH v3 3/8] crypto/aesni_mb: add support for DOCSIS protocol

Coyle, David david.coyle at intel.com
Wed Jul 1 19:04:03 CEST 2020


> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
> index 2d688f4d3..4b25c5e23 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c

<snip>

> @@ -1647,7 +1914,23 @@ cryptodev_aesni_mb_create(const char *name,
>  			RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
>  			RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
>  			RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO |
> -			RTE_CRYPTODEV_FF_SYM_SESSIONLESS;
> +			RTE_CRYPTODEV_FF_SYM_SESSIONLESS
> +#ifdef AESNI_MB_DOCSIS_SEC_ENABLED
> +			| RTE_CRYPTODEV_FF_SECURITY
> +#endif
> +			;
> +
> +#ifdef AESNI_MB_DOCSIS_SEC_ENABLED
> +	security_instance = rte_malloc("aesni_mb_sec",
> +				sizeof(struct rte_security_ctx), 0);
> +	if (security_instance == NULL)
> +		AESNI_MB_LOG(ERR, "rte_security_ctx memory alloc
> failed\n");
> +
> +	security_instance->device = (void *)dev;

[DC] Possible NULL pointer dereference here... will fix in v4

> +	security_instance->ops = rte_aesni_mb_pmd_sec_ops;
> +	security_instance->sess_cnt = 0;
> +	dev->security_ctx = security_instance; #endif
> 


More information about the dev mailing list