[dpdk-dev] [PATCH 1/3] ethdev: add new RSS offload types

[Su, Simei]

Hi, Qi

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang at intel.com>
> Sent: Wednesday, July 1, 2020 9:28 PM
> To: Su, Simei <simei.su at intel.com>; Ye, Xiaolong <xiaolong.ye at intel.com>;
> Xing, Beilei <beilei.xing at intel.com>
> Cc: dev at dpdk.org; Guo, Jia <jia.guo at intel.com>; Guo, Junfeng
> <junfeng.guo at intel.com>
> Subject: RE: [PATCH 1/3] ethdev: add new RSS offload types
> 
> 
> 
> > -----Original Message-----
> > From: Su, Simei <simei.su at intel.com>
> > Sent: Friday, June 12, 2020 10:20 AM
> > To: Zhang, Qi Z <qi.z.zhang at intel.com>; Ye, Xiaolong
> > <xiaolong.ye at intel.com>; Xing, Beilei <beilei.xing at intel.com>
> > Cc: dev at dpdk.org; Guo, Jia <jia.guo at intel.com>; Guo, Junfeng
> > <junfeng.guo at intel.com>; Su, Simei <simei.su at intel.com>
> > Subject: [PATCH 1/3] ethdev: add new RSS offload types
> >
> > This patch defines new RSS offload types for PPPoE and session id is
> > assumed to be the default RSS input set.
> 
> Not sure if it is necessary to force the default RSS input set as session id for
> PPPoE, So maybe reword to below:
> Typically Session Id would be the RSS input set for a PPPoE packet, but as a
> hint each driver may have different default behavior
> 

  I mean if we use ETH_RSS_PPPoE, itself represents the input set "session id". Maybe I can reword:
  session id is assumed to be the default RSS input set for ETH_RSS_PPPoE.
  Do you think it's ok ?

Br
Simei

> >
> > Signed-off-by: Simei Su <simei.su at intel.com>
> > ---
> >  lib/librte_ethdev/rte_ethdev.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev.h
> > b/lib/librte_ethdev/rte_ethdev.h index a49242b..631b146 100644
> > --- a/lib/librte_ethdev/rte_ethdev.h
> > +++ b/lib/librte_ethdev/rte_ethdev.h
> > @@ -521,7 +521,7 @@ struct rte_eth_rss_conf {
> >  #define ETH_RSS_AH                 (1ULL << 28)
> >  #define ETH_RSS_L2TPV3             (1ULL << 29)
> >  #define ETH_RSS_PFCP               (1ULL << 30)
> > -
> > +#define ETH_RSS_PPPOE		   (1ULL << 31)
> >
> >  /*
> >   * We use the following macros to combine with above ETH_RSS_* for
> > --
> > 1.8.3.1
>