[dpdk-dev] [PATCH 7/7] test/crypto: use generic cryptotests for OCTEON TX PMDs

[Ankur Dwivedi]

Hi Akhil,

Please see my response inline.

Thanks
Ankur

>-----Original Message-----
>From: Akhil Goyal <akhil.goyal at nxp.com>
>Sent: Thursday, July 2, 2020 1:53 AM
>To: Ankur Dwivedi <adwivedi at marvell.com>; dev at dpdk.org
>Cc: declan.doherty at intel.com; Anoob Joseph <anoobj at marvell.com>
>Subject: [EXT] RE: [PATCH 7/7] test/crypto: use generic cryptotests for OCTEON
>TX PMDs
>
>External Email
>
>----------------------------------------------------------------------
>Hi Anoob/Ankur,
>> From: Anoob Joseph <anoobj at marvell.com>
>>
>> This patch enables the generic crypto tests for OCTEON TX PMDs.
>> Reomves the PMD specific tests.
>
>Spell check.
[Ankur] Will address this in v2.
>
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi at marvell.com>
>> Signed-off-by: Anoob Joseph <anoobj at marvell.com>
>> ---
>>  app/test/test_cryptodev.c | 769
>> +---------------------------------------------
>>  1 file changed, 2 insertions(+), 767 deletions(-)
>>
>
>Please split this patch into two patches. When I try to apply this patch, The
>contents of this patch gets changed. I believe a lot of similar lines of Code
>make git confused and it jumble up the code.
>So probably, you can remove the PMD specific cases in one patch and
>Testsuite in the other one.
[Ankur] Will address this in v2.
>
>Rename the title of the patch as
>test/crypto: use generic testsuite for OCTEON TX/TX2
[Ankur] Will address this in v2.