[dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows
Kinsella, Ray
mdr at ashroe.eu
Thu Jul 2 16:56:46 CEST 2020
Fady,
Any comments on the below?
Ray K
On 30/06/2020 11:49, Kinsella, Ray wrote:
>
>
> On 22/06/2020 12:55, Fady Bader wrote:
>> Function versioning is not needed on Windows, also the function versioning
>> implementation is not supported by Windows.
>> Function versioning was disabled on Windows.
>>
>> Signed-off-by: Fady Bader <fady at mellanox.com>
>> ---
>> lib/librte_eal/include/rte_function_versioning.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/lib/librte_eal/include/rte_function_versioning.h b/lib/librte_eal/include/rte_function_versioning.h
>> index f588f2643b..cee06602e9 100644
>> --- a/lib/librte_eal/include/rte_function_versioning.h
>> +++ b/lib/librte_eal/include/rte_function_versioning.h
>> @@ -11,6 +11,10 @@
>> #error Use of function versioning disabled, is "use_function_versioning=true" in meson.build?
> Do we need a meson error/rule that catches if people explicitly try to enable function_versioning.
> We don't want to just silently fail under such circumstances?
>
> Would something in lib/meson.build would work better?
>
> if use_function_versioning and target_machine.system == "Windows"
> // complain loudly ...
> endif
>
>> #endif
>>
>> +#ifdef RTE_EXEC_ENV_WINDOWS
>> +#undef RTE_BUILD_SHARED_LIB
>> +#endif
>> +
>> #ifdef RTE_BUILD_SHARED_LIB
>>
>> /*
>>
More information about the dev
mailing list