[dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows

[Fady Bader]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Sunday, July 5, 2020 3:01 PM
> To: Fady Bader <fady at mellanox.com>
> Cc: dev <dev at dpdk.org>; Thomas Monjalon <thomas at monjalon.net>; Tasnim
> Bashar <tbashar at mellanox.com>; Tal Shnaiderman <talshn at mellanox.com>;
> Yohad Tor <yohadt at mellanox.com>; Dmitry Kozlyuk
> <dmitry.kozliuk at gmail.com>; Harini Ramakrishnan
> <harini.ramakrishnan at microsoft.com>; Omar Cardona
> <ocardona at microsoft.com>; Pallavi Kadam <pallavi.kadam at intel.com>; Ranjit
> Menon <ranjit.menon at intel.com>; Olivier Matz <olivier.matz at 6wind.com>;
> Andrew Rybchenko <arybchenko at solarflare.com>; Ray Kinsella
> <mdr at ashroe.eu>; Neil Horman <nhorman at tuxdriver.com>
> Subject: Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows
> 
> On Sun, Jul 5, 2020 at 1:47 PM Fady Bader <fady at mellanox.com> wrote:
> > diff --git a/lib/librte_eal/rte_eal_version.map
> b/lib/librte_eal/rte_eal_version.map
> > index 196eef5afa..9ad843c754 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -395,4 +395,5 @@ INTERNAL {
> >         rte_mem_map;
> >         rte_mem_page_size;
> >         rte_mem_unmap;
> > +       __rte_trace_mem_per_thread_alloc;
> 
> The CI result is not there yet, but I expect issues.
> This symbol is marked as experimental, not internal.
> + it is exported already in the experimental section of the EAL map.

You are right, I'll remove it in the next version of the patch.

> 
> Why did you need this line? 
> 
> 
> --
> David Marchand