[dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows

Fady Bader fady at mellanox.com
Mon Jul 6 09:02:31 CEST 2020



> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Sunday, July 5, 2020 11:24 PM
> To: Fady Bader <fady at mellanox.com>
> Cc: dev at dpdk.org; Tasnim Bashar <tbashar at mellanox.com>; Tal Shnaiderman
> <talshn at mellanox.com>; Yohad Tor <yohadt at mellanox.com>;
> dmitry.kozliuk at gmail.com; harini.ramakrishnan at microsoft.com;
> ocardona at microsoft.com; pallavi.kadam at intel.com; ranjit.menon at intel.com;
> olivier.matz at 6wind.com; arybchenko at solarflare.com; mdr at ashroe.eu;
> nhorman at tuxdriver.com
> Subject: Re: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on
> Windows
> 
> 05/07/2020 15:47, Fady Bader:
> > Function versioning implementation is not supported by Windows.
> > Function versioning was disabled on Windows.
> 
> was -> is
> 
> > Signed-off-by: Fady Bader <fady at mellanox.com>
> > ---
> >  lib/librte_eal/include/rte_function_versioning.h | 2 +-
> >  lib/meson.build                                  | 5 +++++
> >  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> As suggested by Ray, we should add a note in the documentation about the ABI
> compatibility. Because we have no function versioning, we cannot ensure ABI
> compatibility on Windows.
> 
> I recommend adding this text in doc/guides/windows_gsg/intro.rst under
> "Limitations":
> "
> The :doc:`../contributing/abi_policy` cannot be respected for Windows.
> Minor ABI versions may be incompatible
> because function versioning is not supported on Windows.
> "

Ok, I'll send a new patch with the changes soon.

> 



More information about the dev mailing list