[dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues setup

[Wisam Monther]

Hi,

>-----Original Message-----
>From: Thomas Monjalon <thomas at monjalon.net>
>Sent: Sunday, July 5, 2020 11:40 PM
>To: Wisam Monther <wisamm at mellanox.com>
>Cc: Jack Min <jackmin at mellanox.com>; david.marchand at redhat.com;
>dev at dpdk.org; Asaf Penso <asafp at mellanox.com>;
>arybchenko at solarflare.com
>Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues
>setup
>
>30/06/2020 10:10, Wisam Jaddo:
>> The hairpin queue is the one that start from normal rxq, and will be
>> less than nr_queues where nr_queues is the sum of normal and hairpin
>>
>> Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation")
>> Cc: wisamm at mellanox.com
>>
>> Signed-off-by: Wisam Jaddo <wisamm at mellanox.com>
>
>You should take this opportunity to document the logic for the allocation and
>peering of hairpin queues.
>
>It would be good to add short code comments for the variables as well.
>It confusing to have hairpinq and hairpin_q variables.
>
>Currently, we cannot really understand whether this fix is good or not.

I've sent V2 with the fix + those documentation.

>
>On hairpin topic, I suggest fixing this typo:
>	hairping-rss -> hairpin-rss

I've provided another patch to fix this typo:
http://patches.dpdk.org/patch/73162/

>
>