[dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

Ankur Dwivedi adwivedi at marvell.com
Tue Jul 7 08:07:16 CEST 2020


Hi Akhil,

Please see my reply inline.

Thanks
Ankur

>-----Original Message-----
>From: Akhil Goyal <akhil.goyal at nxp.com>
>Sent: Tuesday, July 7, 2020 12:24 AM
>To: Ankur Dwivedi <adwivedi at marvell.com>; dev at dpdk.org
>Cc: declan.doherty at intel.com; Hemant Agrawal
><hemant.agrawal at nxp.com>; Vakul Garg <vakul.garg at nxp.com>; Anoob
>Joseph <anoobj at marvell.com>
>Subject: [EXT] RE: [PATCH] test/crypto: change cipher offset for esn vector
>
>External Email
>
>----------------------------------------------------------------------
>> >Why do we need this change?
>> >The existing test case is to demonstrate a generic case where we can
>> >have an auth only trailer as well. It is similar to a case of IPSEC
>> >ESN but not exactly IPSec. Cipher offset can be anything as per the app
>requirement.
>> >I don't think there is anything wrong in the vector. It should pass
>> >in every hardware without any issue.
>> [Ankur] It's a limitation in OCTEON TX PMDs that the (encr offset -
>> auth offset) should be 8 bytes aligned.
>> In the IPSEC ESN scenario generally the offsets will be such.
>> But in the above IPSEC ESN test vector, this requirement is not met
>> and hence the associated test cases fails on the PMD.
>
>In that case, I think it is better to have a separate test vector and both should
>be executed. With the previous one as not supported in your case and this
>one will be supported.
[Ankur] The offsets values are present per crypto operation. So to make these tests
as unsupported the pmd datapath needs to be changed.
Is there an alternative to make these tests unsupported?



More information about the dev mailing list