[dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status

Phil Yang Phil.Yang at arm.com
Thu Jul 9 07:17:51 CEST 2020


> -----Original Message-----
> From: Harman Kalra <hkalra at marvell.com>
> Sent: Wednesday, July 8, 2020 7:41 PM
> To: Phil Yang <Phil.Yang at arm.com>
> Cc: dev at dpdk.org; drc at linux.vnet.ibm.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli at arm.com>; Ruifeng Wang
> <Ruifeng.Wang at arm.com>; nd <nd at arm.com>
> Subject: Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status
> 
> On Thu, Jun 11, 2020 at 06:24:25PM +0800, Phil Yang wrote:
> > The event status is defined as a volatile variable and shared
> > between threads. Use c11 atomics with explicit ordering instead
> > of rte_atomic ops which enforce unnecessary barriers on aarch64.
> >
> > Signed-off-by: Phil Yang <phil.yang at arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> > ---
> 
> Patches looks fine to me with commit message changes suggested
> by Honnappa, i.e. using C11 atomic built-ins.
> Since first patch of the series will not be backported, so I
> think both patches can be combined into one.

OK. Thanks. 
I will update in the next version.

Thanks,
Phil

> 
> Reviewed-by: Harman Kalra <hkalra at marvell.com>
> 
<snip>


More information about the dev mailing list