[dpdk-dev] [PATCH v2 12/20] net/ixgbe/base: modify coding style

[Sun, GuinanX]

Hi Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, July 8, 2020 11:26 PM
> To: Sun, GuinanX <guinanx.sun at intel.com>; dev at dpdk.org; Zhang, Qi Z
> <qi.z.zhang at intel.com>
> Cc: Guo, Jia <jia.guo at intel.com>; Zhao1, Wei <wei.zhao1 at intel.com>;
> Chylkowski, JakubX <jakubx.chylkowski at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 12/20] net/ixgbe/base: modify coding style
> 
> On 7/2/2020 4:13 AM, Guinan Sun wrote:
> > Fix unchecked return value.
> > Add cast for type mismatch.
> >
> > Signed-off-by: Jakub Chylkowski <jakubx.chylkowski at intel.com>
> > Signed-off-by: Guinan Sun <guinanx.sun at intel.com>
> > ---
> >  drivers/net/ixgbe/base/ixgbe_82599.c     | 12 +++++-------
> >  drivers/net/ixgbe/base/ixgbe_common.c    |  6 ++----
> >  drivers/net/ixgbe/base/ixgbe_common.h    |  2 +-
> >  drivers/net/ixgbe/base/ixgbe_dcb_82598.c |  2 +-
> > drivers/net/ixgbe/base/ixgbe_dcb_82599.c |  2 +-
> >  drivers/net/ixgbe/base/ixgbe_phy.c       | 25 +++++++-----------------
> >  drivers/net/ixgbe/base/ixgbe_x540.c      |  2 +-
> >  drivers/net/ixgbe/base/ixgbe_x550.c      |  2 +-
> >  8 files changed, 19 insertions(+), 34 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c
> > b/drivers/net/ixgbe/base/ixgbe_82599.c
> > index 193233746..e425f28af 100644
> > --- a/drivers/net/ixgbe/base/ixgbe_82599.c
> > +++ b/drivers/net/ixgbe/base/ixgbe_82599.c
> > @@ -1547,7 +1547,7 @@ void ixgbe_fdir_add_signature_filter_82599(struct
> ixgbe_hw *hw,
> >  	 * is for FDIRCMD.  Then do a 64-bit register write from FDIRHASH.
> >  	 */
> >  	fdirhashcmd = (u64)fdircmd << 32;
> > -	fdirhashcmd |= ixgbe_atr_compute_sig_hash_82599(input, common);
> > +	fdirhashcmd |= (u64)ixgbe_atr_compute_sig_hash_82599(input,
> common);
> 
> Hi Guinan, Qi,
> 
> These are not coding style changes, as commit log says they are fixes in the
> code.
> 
> Can you please properly separate the patch based on the fix type and provide
> relevant patch title?

First, we will make changes to the commit log.
The reason is that this is not a fix, but some unnecessary return value check is deleted.
Secondly, we split this patch into two. This will make the expression clearer.