[dpdk-dev] [PATCH v2 4/6] net/i40e: replace restrict with rte restrict

[David Marchand]

On Wed, Jul 8, 2020 at 5:21 AM Joyce Kong <Joyce.Kong at arm.com> wrote:
>
> > -----Original Message-----
> > From: David Marchand <david.marchand at redhat.com>
> > Sent: Tuesday, July 7, 2020 10:00 PM
> > To: Joyce Kong <Joyce.Kong at arm.com>
> > Cc: Maxime Coquelin <maxime.coquelin at redhat.com>; jerinj at marvell.com;
> > Zhihong Wang <zhihong.wang at intel.com>; Xiaolong Ye
> > <xiaolong.ye at intel.com>; Beilei Xing <beilei.xing at intel.com>; Jeff Guo
> > <jia.guo at intel.com>; Mcnamara, John <john.mcnamara at intel.com>; Matan
> > Azrad <matan at mellanox.com>; Shahaf Shuler <shahafs at mellanox.com>;
> > Viacheslav Ovsiienko <viacheslavo at mellanox.com>; Honnappa Nagarahalli
> > <Honnappa.Nagarahalli at arm.com>; Phil Yang <Phil.Yang at arm.com>;
> > Ruifeng Wang <Ruifeng.Wang at arm.com>; dev <dev at dpdk.org>; nd
> > <nd at arm.com>
> > Subject: Re: [dpdk-dev] [PATCH v2 4/6] net/i40e: replace restrict with rte
> > restrict
> >
> > On Mon, Jul 6, 2020 at 9:50 AM Joyce Kong <joyce.kong at arm.com> wrote:
> > >
> > > '__rte_restrict' is a common wrapper for restricted pointers which can
> > > be supported by all compilers. Use '__rte_restrict' instead of
> > > '__restrict' for code consistency.
> >
> > This patch 4, 5 and 6 are simple replacements and can be squashed into the
> > first patch.
> >
> > Thanks.
> >
> The first patch is to add a common definition for lib_eal, could we squash the 4,5 and 6
> into one replacement patch, while separate them from the first one?
> This might be more convenient for review?

A copy/paste commitlog hints that it did not deserve separate patches.
About easing reviews, the changes are mechanical, there is no special case.
I am not convinced but, go as you like.

Can you provide a new revision wrt patch 1 problem?
Thanks.


-- 
David Marchand