[dpdk-dev] [PATCH 2/5] net/mlx5: add flow translation of eCPRI header

[Bing Zhao]

Got it, I will add it.
Thanks for your comments.

BR. Bing

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Thursday, July 9, 2020 8:22 PM
> To: Bing Zhao <bingz at mellanox.com>
> Cc: Ori Kam <orika at mellanox.com>; Slava Ovsiienko
> <viacheslavo at mellanox.com>; Raslan Darawsheh
> <rasland at mellanox.com>; Matan Azrad <matan at mellanox.com>;
> dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/5] net/mlx5: add flow translation of
> eCPRI header
> 
> 08/07/2020 16:43, Bing Zhao:
> > In the translation stage, the eCPRI item should be translated into the
> > format that lower layer driver could use. All the fields that need to
> > matched must be in network byte order after translation, as well as
> > the mask. Since the header in the item belongs to the network layers
> > stack, and the input parameter of the header is considered to be in
> > big-endian format already.
> >
> > Base on the definition in the PRM, the DW samples will be used for
> > matching in the FTE/STE. Now, the type field and only the PC ID, RTC
> > ID, and DLY MSR ID of the payload will be supported. The masks
> should
> > be 00 ff 00 00 ff ff(00) 00 00 in the network order. Two DWs are
> > needed to support such matching. The mask fields could be zeros to
> > support some wildcard rules. But it makes no sense to support the
> rule
> > matching only on the payload but without matching type filed.
> >
> > The DW samples should be stored after the flex parser creation for
> > eCPRI. There is no need to query the sample IDs each time when
> > creating a flow rule with eCPRI item. It will not introduce insertion
> > rate degradation significantly.
> >
> > Signed-off-by: Bing Zhao <bingz at mellanox.com>
> > ---
> >  drivers/common/mlx5/mlx5_prm.h  |  16 ++++-
> >  drivers/net/mlx5/mlx5.h         |  15 +++++
> >  drivers/net/mlx5/mlx5_flow_dv.c | 130
> > ++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 160 insertions(+), 1 deletion(-)
> 
> In this patch, you could add the feature in the release notes, as part of
> mlx5 section, and probably in the mlx5 guide too.
> 
> 
>