[dpdk-dev] [PATCH v3 03/10] check_maintainers: change variable names

Thomas Monjalon thomas at monjalon.net
Fri Jul 10 19:01:09 CEST 2020


13/06/2020 02:00, Stephen Hemminger:
> Use blocklist where blacklist was used and allowlist
> where whitelist was used.

This is a mechanical, not accurate, replacement.

> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> Acked-by: Luca Boccassi <bluca at debian.org>
> ---
> --- a/devtools/check-maintainers.sh
> +++ b/devtools/check-maintainers.sh
>  			# empty line delimit end of section
> -			whitelist=$(files $flines)
> -			blacklist=$(files $xlines)
> -			match=$(aminusb "$whitelist" "$blacklist")
> -			if [ -n "$whitelist" ] ; then
> +			allowlist=$(files $flines)
> +			blocklist=$(files $xlines)
> +			match=$(aminusb "$allowlist" "$blocklist")
> +			if [ -n "$allowlist" ] ; then
>  				printf "# $title "

It is listing files with exclusions.
The concept allow/block does not match here.
I would prefer "files" and "xfiles" as variable names.




More information about the dev mailing list