[dpdk-dev] [PATCH v2] eal/windows: detect insufficient privileges for hugepages

Thomas Monjalon thomas at monjalon.net
Fri Jul 10 23:25:13 CEST 2020


09/07/2020 00:27, Ranjit Menon:
> On 7/8/2020 2:48 PM, Dmitry Kozlyuk wrote:
> > AdjustTokenPrivileges() succeeds even if no requested privileges have
> > been granted; this behavior is documented. Check last error code in
> > addition to return value to detect such case.
> >
> > Make error messages more specific and add troubleshooting hint.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
[...]
> >   	if (hugepage_claim_privilege() < 0) {
> > -		RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n");
> > +		RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n"
> > +			"Verify that large-page support privilege "
> > +			"is assigned to the current user\n");

The error message can be searched in the code,
so it is better not to break lines.

> Acked-by: Ranjit Menon <ranjit.menon at intel.com>

Applied with merged log lines, thanks.





More information about the dev mailing list