[dpdk-dev] [PATCH v4 05/27] drivers: replace master/slave terminology
Burakov, Anatoly
anatoly.burakov at intel.com
Mon Jul 13 14:52:53 CEST 2020
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote:
> Replace rte_get_master_lcore() with rte_get_initial_lcore().
> Replace RTE_LCORE_FOREACH_SLAVE with RTE_LCORE_FOREACH_WORKER
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
Comments in pci_common_uio.c:54 and vmbus_common_uio.c:88 refers to
secondary process as "slave", should probably fix that too.
You mentioned "bonding" driver as needing work but there's actually a
whole bunch of instances of such terminology being used internally in
other drivers as well (e.g. cryptodev scheduler). A quick grep on
"master|slave" gives us a huge list of files, and while some of them are
spec terms (e.g. PCI bus mastering), a lot of them aren't. I'm of course
not suggesting it all should be done in this patch, just noting that
bonding isn't the only driver needing work :)
As for contents of this patch (provided the corrections mentioned above
are done),
Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>
--
Thanks,
Anatoly
More information about the dev
mailing list