[dpdk-dev] [PATCH v2 02/20] regex/mlx5: add log utils

Thomas Monjalon thomas at monjalon.net
Wed Jul 15 19:32:30 CEST 2020


12/07/2020 22:58, Ori Kam:
> From: Yuval Avnery <yuvalav at mellanox.com>
> 
> Add the DRV_LOG macro which should be used for error prints.

Should be MLX5_REGEX_LOG

> +extern int mlx5_regex_logtype;
> +
> +#define MLX5_REGEX_LOG_PREFIX "regex_mlx5"
> +/* Generic printf()-like logging macro with automatic line feed. */
> +#define DRV_LOG(level, ...) \
> +	PMD_DRV_LOG_(level, mlx5_regex_logtype, MLX5_REGEX_LOG_PREFIX, \
> +		__VA_ARGS__ PMD_DRV_LOG_STRIP PMD_DRV_LOG_OPAREN, \
> +		PMD_DRV_LOG_CPAREN)

Was it tested?
I don't see where the log type is registered.

Please use RTE_LOG_REGISTER





More information about the dev mailing list