[dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

Ferruh Yigit ferruh.yigit at intel.com
Fri Jul 17 14:35:50 CEST 2020


On 7/17/2020 4:19 AM, Xia, Chenbo wrote:
> 
>> -----Original Message-----
>> From: Fu, Patrick <patrick.fu at intel.com>
>> Sent: Wednesday, July 15, 2020 11:59 PM
>> To: dev at dpdk.org; maxime.coquelin at redhat.com; Xia, Chenbo
>> <chenbo.xia at intel.com>
>> Cc: Wang, Yinan <yinan.wang at intel.com>; Fu, Patrick <patrick.fu at intel.com>
>> Subject: [PATCH v1] vhost: set zmbufs to NULL when freed
>>
>> From: Patrick Fu <patrick.fu at intel.com>
>>
>> zmbufs should be set to NULL when getting freed to avoid double free on the
>> same buffer pointer
>>
>> Fixes: b0a985d1f340 ("vhost: add dequeue zero copy")
>>
>> Signed-off-by: Patrick Fu <patrick.fu at intel.com>
>> ---
>>  lib/librte_vhost/vhost_user.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index
>> df0db8a07..9ddeae362 100644
>> --- a/lib/librte_vhost/vhost_user.c
>> +++ b/lib/librte_vhost/vhost_user.c
>> @@ -1934,6 +1934,7 @@ free_zmbufs(struct vhost_virtqueue *vq)
>>  	drain_zmbuf_list(vq);
>>
>>  	rte_free(vq->zmbufs);
>> +	vq->zmbufs = NULL;
>>  }
>>
>>  /*
>> --
>> 2.17.1
> 
> Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
> 

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list