[dpdk-dev] [PATCH v4 22/27] doc: update references to master/slave lcore in documentation

Burakov, Anatoly anatoly.burakov at intel.com
Fri Jul 17 16:01:01 CEST 2020


On 01-Jul-20 9:23 PM, Stephen Hemminger wrote:
> New terms are initial and worker lcores.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---

<snip>

> +* **Renamed master lcore to initial lcore.**
> +
> +  The name given to the first thread in DPDK is changed from master lcore to initial lcore.
>   
>   Removed Items
>   -------------
> @@ -122,7 +125,6 @@ Removed Items
>   
>   * Removed ``RTE_KDRV_NONE`` based PCI device driver probing.
>   
> -

Accidental whitespace change?

<snip>

> @@ -310,8 +310,8 @@ If initialization is successful, memory for hardware device
>   statistics is allocated.
>   
>   Finally ``main()`` function starts all packet handling lcores and starts
> -printing stats in a loop on the master lcore. The application can be
> -interrupted and closed using ``Ctrl-C``. The master lcore waits for
> +printing stats in a loop on the initial lcore. The application can be
> +interrupted and closed using ``Ctrl-C``. The initial lcore waits for
>   all slave processes to finish, deallocates resources and exits.

Missed updating a line right below the changes. Also, i think worker 
cores were meant, not secondary processes.

<snip>

>                       /* reset the timer */
> diff --git a/doc/guides/sample_app_ug/multi_process.rst b/doc/guides/sample_app_ug/multi_process.rst
> index f2a79a639763..51b8db5cf75a 100644
> --- a/doc/guides/sample_app_ug/multi_process.rst
> +++ b/doc/guides/sample_app_ug/multi_process.rst
> @@ -66,7 +66,7 @@ The process should start successfully and display a command prompt as follows:
>   
>       EAL: check igb_uio module
>       EAL: check module finished
> -    EAL: Master core 0 is ready (tid=54e41820)
> +    EAL: Initial core 0 is ready (tid=54e41820)

I believe you've missed updating a similar place (EAL logs) in quick 
start guide.

-- 
Thanks,
Anatoly


More information about the dev mailing list