[dpdk-dev] [PATCH] lib/librte_eal/common/rte_malloc: remove redundant check for size and alignment

Burakov, Anatoly anatoly.burakov at intel.com
Fri Jul 17 16:49:10 CEST 2020


On 17-Jul-20 3:40 PM, Burakov, Anatoly wrote:
> On 15-Jul-20 2:31 PM, Sarosh Arif wrote:
>> Since mallock_socket() always calls malloc_heap_alloc() and
>> this check is present inside malloc_heap_alloc() so there is
>> no need to place it in mallock_socket().
>>
>> Signed-off-by: Sarosh Arif <sarosh.arif at emumba.com>
>> ---
> 
> Technically not a bug, so i don't think backporting this is necessary.
> 
> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
> 
Actually, now that i think of it, i agree with Lukasz - while this check 
isn't necessary, it's an early exit to avoid memory locking. So, NACK.

-- 
Thanks,
Anatoly


More information about the dev mailing list