[dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

[Burakov, Anatoly]

On 17-Jul-20 4:35 PM, Dmitry Kozliuk wrote:
> On Fri, Jul 17, 2020, 18:21 Burakov, Anatoly <anatoly.burakov at intel.com 
> <mailto:anatoly.burakov at intel.com>> wrote:
> 
>     On 16-Jul-20 11:04 PM, Stephen Hemminger wrote:
>      > On Thu, 16 Jul 2020 14:41:41 +0100
>      > "Burakov, Anatoly" <anatoly.burakov at intel.com
>     <mailto:anatoly.burakov at intel.com>> wrote:
>      >
>      >> On 15-Jul-20 9:29 PM, Stephen Hemminger wrote:
>      >>> On Wed, 15 Jul 2020 14:28:17 +0100
>      >>> "Burakov, Anatoly" <anatoly.burakov at intel.com
>     <mailto:anatoly.burakov at intel.com>> wrote:
>      >>>
>      >>>>> -#define SKIP_MASTER      SKIP_INITIAL
>      >>>>> -#define CALL_MASTER      CALL_INITIAL
>      >>>>> +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is
>     deprecated\"") SKIP_INITIAL
>      >>>>> +#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is
>     deprecated\"") CALL_INITIAL
>      >>>>
>      >>>> Presumably this is a generic header, should we introduce
>     GCC-specific
>      >>>> things there?
>      >>>
>      >>> It works with Clang as well. Likely ICC but don't have that.
>      >>>
>      >>
>      >> What about MSVC?
> 
> 
> FYI, DPDK on Windows is compiled with Clang, only linker is from MSVC. 
> And MinGW uses GCC toolchain. Why care about MSVC here?

Ah, OK. I'm not too familiar with Windows port, i was assuming it uses MSVC.

-- 
Thanks,
Anatoly