[dpdk-dev] 回复: [dpdk-stable] [PATCH V2] net/bonding: delete redundant code
自控潘冬洋
197020236 at qq.com
Sat Jul 18 04:29:19 CEST 2020
Ok, my signature is :
Dongyang Pan <197020236 at qq.com>
Thanks!
------------------ 原始邮件 ------------------
发件人: "Ferruh Yigit" <ferruh.yigit at intel.com>;
发送时间: 2020年7月17日(星期五) 晚上8:46
收件人: "自控潘冬洋"<197020236 at qq.com>;
抄送: "Wei Hu (Xavier)"<xavier.huwei at huawei.com>;"dev"<dev at dpdk.org>;"stable"<stable at dpdk.org>;
主题: Re: [dpdk-stable] [PATCH V2] net/bonding: delete redundant code
On 7/17/2020 12:22 PM, Wei Hu (Xavier) wrote:
> Reviewed-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
>
>
> On 2020/7/4 9:22, Wei Hu (Xavier) wrote:
>>
>>
>> On 2020/7/4 9:15, 197020236 at qq.com wrote:
>>> From: pandongyang <197020236 at qq.com>
>>>
>>> The function valid_bonded_port_id() has already contains function
>>> rte_eth_dev_is_valid_port(), so delete redundant check.
>>>
>>> Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
>>> Cc: stable at dpdk.org
>>>
>>> Signed-off-by: pandongyang <197020236 at qq.com>
Hi pandongyang,
Can you please provide the sign-off in following format:
Name Surname <email at address.com>
We need this to be able to accept the patch.
Thanks,
ferruh
>> Reviewed-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
>>> ---
>>> v1 -> v2: Adjust commit info
>>> ---
>>> drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> b/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> index b77a37ddb..339374337 100644
>>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> @@ -1675,9 +1675,6 @@
>>> rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
>>> dev = &rte_eth_devices[port];
>>> internals = dev->data->dev_private;
>>> - if (check_for_bonded_ethdev(dev) != 0)
>>> - return -1;
>>> -
>>> if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
>>> return -1;
>>> @@ -1704,9 +1701,6 @@
>>> rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
>>> dev = &rte_eth_devices[port];
>>> internals = dev->data->dev_private;
>>> - if (check_for_bonded_ethdev(dev) != 0)
>>> - return -1;
>>> -
>>> /* Device must be stopped to set up slow queue */
>>> if (dev->data->dev_started)
>>> return -1;
>>
>
More information about the dev
mailing list