[dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

Slava Ovsiienko viacheslavo at mellanox.com
Sun Jul 19 12:11:11 CEST 2020


> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Sunday, July 19, 2020 13:08
> To: dev at dpdk.org
> Cc: Raslan Darawsheh <rasland at mellanox.com>; Shiri Kuzin
> <shirik at mellanox.com>; stable at dpdk.org; Matan Azrad
> <matan at mellanox.com>; Shahaf Shuler <shahafs at mellanox.com>; Slava
> Ovsiienko <viacheslavo at mellanox.com>; Ray Kinsella <mdr at ashroe.eu>;
> Neil Horman <nhorman at tuxdriver.com>
> Subject: [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering
> 
> The detection of the CPU was done in a constructor and shared in a global
> variable.
> 
> This variable may not be visible in the net PMD because it was not exported
> as part of the .map file.
> It is fixed by exporting a function, which is cleaner than a variable.
> 
> By checking the CPU only at the first call of the function, doing the check in a
> constructor becomes useless.
> Note: the priority of the constructor was probably irrelevant.
> 
> At the same time, the comments are reworded or dropped if useless.
> 
> Fixes: 4c204fe5e5d2 ("common/mlx5: disable relaxed ordering in unsuitable
> CPUs")
> Cc: shirik at mellanox.com
> Cc: stable at dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
Acked-by: Viacheslav Ovsiienko <viacheslavo at mellanox.com>


More information about the dev mailing list