[dpdk-dev] [PATCH v3 8/8] crypto/octeontx2: add cryptodev sec enqueue and dequeue routines

[Ferruh Yigit]

On 7/16/2020 9:39 AM, Tejasree Kondoj wrote:
> From: Vamsi Attunuru <vattunuru at marvell.com>
> 
> This patch adds lookaside IPsec enqueue and dequeue routines.
> 
> Signed-off-by: Vamsi Attunuru <vattunuru at marvell.com>
> Signed-off-by: Tejasree Kondoj <ktejasree at marvell.com>

<...>

> @@ -33,6 +34,13 @@ struct otx2_cpt_vf {
>  	/**< CPT device capabilities */
>  };
>  
> +struct cpt_meta_info {
> +	uint64_t deq_op_info[4];
> +	uint64_t comp_code_sz;
> +	union cpt_res_s cpt_res __rte_aligned(16);
> +	struct cpt_request_info cpt_req __rte_aligned(8);
> +};

"struct cpt_request_info" already has cache size alignment (__rte_cache_aligned)
[1].

Trying to align it to 8 bytes is reducing the alignment, gcc & clang seems
silently ignoring this case but icc is giving a warning.

Since it is already ignored, and I assume the real intention is not to reduce
the alignment, can you please remove the above "__rte_aligned(8)"?


@Thomas, it is still good to have icc around to catch additional issues ;)


[1]
http://lxr.dpdk.org/dpdk/v20.05/source/drivers/common/cpt/cpt_common.h#L79