[dpdk-dev] [PATCH v3] vhost: fix missing device pointer validity check
patrick.fu at intel.com
patrick.fu at intel.com
Tue Jul 21 05:23:04 CEST 2020
From: Patrick Fu <patrick.fu at intel.com>
This patch adds the check of dev pointer in vhost async enqueue
completion poll. If a NULL dev pointer detected, the poll function
returns immediately.
Coverity issue: 360839
Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
Signed-off-by: Patrick Fu <patrick.fu at intel.com>
---
v2:
- change fixline number
v3:
- revise commit message title
lib/librte_vhost/virtio_net.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 1d0be3dd4..235c31e28 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -1635,6 +1635,9 @@ uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t queue_id,
uint16_t start_idx, pkts_idx, vq_size;
uint64_t *async_pending_info;
+ if (!dev)
+ return 0;
+
VHOST_LOG_DATA(DEBUG, "(%d) %s\n", dev->vid, __func__);
if (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->nr_vring))) {
VHOST_LOG_DATA(ERR, "(%d) %s: invalid virtqueue idx %d.\n",
--
2.18.4
More information about the dev
mailing list