[dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug

Trahe, Fiona fiona.trahe at intel.com
Fri Jul 24 13:54:31 CEST 2020



> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski at intel.com>
> Sent: Friday, July 24, 2020 10:40 AM
> To: dev at dpdk.org; Trahe, Fiona <fiona.trahe at intel.com>; akhil.goyal at nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski at intel.com>
> Subject: [PATCH] common/qat: fix uninitialized variable bug
> 
> This patch fixes the uninitialized variable bug in QAT PMD.
> 
> Fixes: 9f27a860dc16 ("crypto/qat: move generic qp function to qp file")
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski at intel.com>
> ---
>  drivers/common/qat/qat_qp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
> index aacd4ab21..0ee713955 100644
> --- a/drivers/common/qat/qat_qp.c
> +++ b/drivers/common/qat/qat_qp.c
> @@ -582,7 +582,7 @@ qat_enqueue_op_burst(void *qp, void **ops, uint16_t nb_ops)
>  	register struct qat_queue *queue;
>  	struct qat_qp *tmp_qp = (struct qat_qp *)qp;
>  	register uint32_t nb_ops_sent = 0;
> -	register int ret;
> +	register int ret = -1;
Nack - this fn returns an unsigned. So the correct option is to default to 0







More information about the dev mailing list