[dpdk-dev] [PATCH 3/8] net/i40e/base: enable new custom cloud filters

[Sun, GuinanX]

Hi Jeff

> -----Original Message-----
> From: Guo, Jia
> Sent: Monday, July 27, 2020 11:53 AM
> To: Sun, GuinanX <guinanx.sun at intel.com>; dev at dpdk.org
> Cc: Xing, Beilei <beilei.xing at intel.com>; Ramamurthy, Harshitha
> <harshitha.ramamurthy at intel.com>
> Subject: Re: [PATCH 3/8] net/i40e/base: enable new custom cloud filters
> 
> hi, guinan
> 
> This patch is just define some new types but not enable a feature, could the
> title to be "add new custom cloud filters types",
> 
> is it better and could eliminate some confuse?

I agree with you.
Patch V2 will modify it.

> 
> On 7/21/2020 3:39 PM, Guinan Sun wrote:
> > This patch adds the new filter types needed for custom cloud filters.
> > These custom cloud filters will route traffic to VFs based on the dst
> > IP for both tunneled and non-tunneled packets.
> >
> > Signed-off-by: Harshitha Ramamurthy <harshitha.ramamurthy at intel.com>
> > Signed-off-by: Guinan Sun <guinanx.sun at intel.com>
> > ---
> >   drivers/net/i40e/base/i40e_adminq_cmd.h | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h
> > b/drivers/net/i40e/base/i40e_adminq_cmd.h
> > index f790183be..21f544840 100644
> > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h
> > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h
> > @@ -1406,6 +1406,8 @@ struct i40e_aqc_cloud_filters_element_data {
> >   #define I40E_AQC_ADD_CLOUD_FILTER_IMAC
> 	0x000A
> >   #define I40E_AQC_ADD_CLOUD_FILTER_OMAC_TEN_ID_IMAC
> 	0x000B
> >   #define I40E_AQC_ADD_CLOUD_FILTER_IIP			0x000C
> > +#define I40E_AQC_ADD_CLOUD_FILTER_OIP1
> 	0x0010
> > +#define I40E_AQC_ADD_CLOUD_FILTER_OIP2
> 	0x0012
> >   /* 0x000D reserved */
> >   /* 0x000E reserved */
> >   /* 0x000F reserved */