[dpdk-dev] [PATCH] net/virtio-user: fix virtio net status management

Maxime Coquelin maxime.coquelin at redhat.com
Tue Jul 28 17:54:40 CEST 2020



On 7/28/20 8:52 AM, Xiao Wang wrote:
> Apart from the virtio status, there should be also a network related
> status for link status management, current implementation mixes up these
> two statuses.
> 
> One issue caused by this mixup is when virtio-user running in server mode
> and vhost as a client connects to it, a RARP packet will be generated by
> virtio-user due to VIRTIO_NET_S_ANNOUNCE bit is detected in the "status"
> in interrupt handler.
> 
> VIRTIO_NET_S_LINK_UP and VIRTIO_NET_S_ANNOUNCE should be managed by a
> separated field. This patch adds a "net_status" field for this purpose.
> 
> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>
> ---
>  drivers/net/virtio/virtio_user/virtio_user_dev.h |  1 +
>  drivers/net/virtio/virtio_user_ethdev.c          | 10 +++++-----
>  2 files changed, 6 insertions(+), 5 deletions(-)

Applied to dpdk-next-virtio/master

Thanks,
Maxime



More information about the dev mailing list