[dpdk-dev] [PATCH v4 16/22] net/bnxt: fix table reference count for shadow tcam

Ajit Khaparde ajit.khaparde at broadcom.com
Tue Jul 28 19:33:55 CEST 2020


On Tue, Jul 28, 2020 at 10:00 AM Ferruh Yigit <ferruh.yigit at intel.com>
wrote:

> On 7/28/2020 7:34 AM, Ajit Khaparde wrote:
> > From: Mike Baucom <michael.baucom at broadcom.com>
> >
> > Moved setting the refcnt for shadow tcam and table entries to the
> > allocation path only.  The insert can be called multiple times for
> > updates and was resetting the refcnt to 1 each time.  Now multiple
> > insertion/modifications will not change the reference count.
> >
> > Fixes: 3cf8fb975df9 ("net/bnxt: add shadow and search capability to
> tcam")
> >
> > Signed-off-by: Mike Baucom <michael.baucom at broadcom.com>
> > Reviewed-by: Kishore Padmanabha <kishore.padmanabha at broadcom.com>
>
> The fix patch already in this set, why not fix the issue at first place
> where it
> is introduced?
>
> This patch distributed to 1/22 & 12/22 while merging, please confirm.
>
Ferruh,
I took a quick look at the patches and I think we may be able to merge them.
But I have not squashed and compiled the patches yet. So I can't tell if
merging them
will break the build.

Thanks
Ajit


More information about the dev mailing list