[dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case
Thomas Monjalon
thomas at monjalon.net
Thu Jul 30 12:16:34 CEST 2020
30/07/2020 11:56, yang_y_yi at 163.com:
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *m)
> RTE_ASSERT(m->shinfo != NULL);
>
> if (rte_mbuf_ext_refcnt_update(m->shinfo, -1) == 0)
> - m->shinfo->free_cb(m->buf_addr, m->shinfo->fcb_opaque);
> + m->shinfo->free_cb(m, m->shinfo->fcb_opaque);
> }
>
> /**
> diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
> index 8cd7137..d194429 100644
> --- a/lib/librte_mbuf/rte_mbuf_core.h
> +++ b/lib/librte_mbuf/rte_mbuf_core.h
> @@ -671,7 +671,7 @@ struct rte_mbuf {
> /**
> * Function typedef of callback to free externally attached buffer.
> */
> -typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void *opaque);
> +typedef void (*rte_mbuf_extbuf_free_callback_t)(struct rte_mbuf *, void *);
I think a deprecation notice is required in 20.08
in order to apply such change in 20.11.
Please use --cc-cmd devtools/get-maintainer.sh when sending a patch.
More information about the dev
mailing list