[dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask

Thomas Monjalon thomas at monjalon.net
Thu Jul 30 23:18:28 CEST 2020


05/06/2020 15:41, Sarosh Arif:
> Giving invalid or zero portmask as command line option to 
> packet_ordering application will have an unexpected response.
> The reason behind this is that parse_portmask's return value is
> stored in a variable called portmask.The data type of portmask 
> is unsigned int, hence returning -1 in case of zero or invalid
> portmask causes an unexpected behaviour. 
> If we return 0 instead of -1 this issue can be resolved.
> The program already contains the functionality to print
> "invalid portmask" and program usage if portmask is zero.
> 
> Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> 
> Signed-off-by: Sarosh Arif <sarosh.arif at emumba.com>

Merged with same fix for other examples, thanks.




More information about the dev mailing list