[dpdk-dev] [PATCH v3] cmdline: increase maximum line length

Olivier Matz olivier.matz at 6wind.com
Fri Jul 31 14:55:16 CEST 2020


Hi,

Ressurecting this old thread.

On Sat, Feb 22, 2020 at 04:28:15PM +0100, David Marchand wrote:
> This patch is flagged as an ABI breakage:
> https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273
> 

In case we want this fix for 20.11, should we do a deprecation notice
in 20.08?


Olivier


> 
> On Thu, Feb 20, 2020 at 3:53 PM Wisam Jaddo <wisamm at mellanox.com> wrote:
> >
> > This increase due to the usage of cmdline in dpdk applications
> > as config commands such as testpmd do for rte_flow rules creation.
> >
> > The current size of buffer is not enough to fill
> > many cases of rte_flow commands validation/creation.
> >
> > rte_flow now can have outer items, inner items, modify
> > actions, meta data actions, duplicate action, fate action and
> > more in one single rte flow, thus 512 char will not be enough
> > to validate such rte flow rules.
> >
> > Such change shouldn't affect the memory since the cmdline
> > reading again using the same buffer.
> 
> I don't get your point here.
> 
> 
> > Cc: stable at dpdk.org
> 
> This is not a fix.
> 
> 
> -- 
> David Marchand
> 


More information about the dev mailing list