[dpdk-dev] [PATCH v1] net/axgbe: add support for utility APIs

[Ferruh Yigit]

On 6/1/2020 2:57 PM, selwin.sebastian at amd.com wrote:
> From: Selwin Sebastian <selwin.sebastian at amd.com>
> 
> Add support for rx, tx queue utility APIs
> Add support for 'fw_revision_get' API
> 
> Signed-off-by: Selwin Sebastian <selwin.sebastian at amd.com>

Hi Selwin,

Can you please split this patch into three patches,
1) rx/tx queue start/stop
Please add "Queue start/stop" support in 'axgbe.ini' in this patch
2) Fw version get, and announce "FW version" in .ini file
3) Runtime Rx/Tx queue setup capability, and announce "Runtime Rx queue setup" &
"Runtime Tx queue setup" in .ini file

<...>

> @@ -565,6 +565,95 @@ int axgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
>  	return 0;
>  }
>  
> +int axgbe_dev_tx_queue_start(struct rte_eth_dev *eth_dev,
> +		uint16_t queue_idx)
> +{

According coding convention return type should be in above line, this file has
both syntax which is worst. Is there any reason to comply to coding convention
sometimes but not comply other times?