[dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU command

Ferruh Yigit ferruh.yigit at intel.com
Tue Jun 9 16:59:21 CEST 2020


On 6/9/2020 3:44 PM, Phil Yang wrote:
>> -----Original Message-----
>> From: dev <dev-bounces at dpdk.org> On Behalf Of Shy Shyman
>> Sent: Monday, June 8, 2020 10:18 PM
>> To: dev at dpdk.org
>> Cc: wenzhuo.lu at intel.com; beilei.xing at intel.com;
>> bernard.iremonger at intel.com; xavier.huwei at huawei.com
>> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU
>> command
>>
>> MTU is used in testpmd to set the maximum payload size for packets.
>> According to testpmd, the setting influnce RX only.
>> In rte_ethdev there's no relation between MTU setting and JUMBO offload
>> or
>> rx_max_pkt_len.
>>
>> The previous fix in patch referenced below was meant to update the
>> correlated variables of max_pkt_len and JUMBO offload, but by doing
>> so it assumes that MTU setting can only exist when JUMBO offload
>> supported in the device. For example fail-safe device does supports set MTU
>> and doesn't support JUMBO offload, and in this case, though set MTU
>> succeeds, an error message is still printed since the JUMBO packet
>> offload is disabled.
>>
>> The fix separates the two conditions to make sure the error
>> triggers only in case the set_mtu action actually failed.
>>
>> Fixes: 150c9ac2df13 ("app/testpmd: update Rx offload after setting MTU")
>> Cc: xavier.huwei at huawei.com
>>
>> Signed-off-by: Shy Shyman <shys at mellanox.com>
> 
> Reviewed-by: Phil Yang <phil.yang at arm.com>
> 

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list