[dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

Thomas Monjalon thomas at monjalon.net
Fri Jun 12 23:37:51 CEST 2020


12/06/2020 22:24, Dmitry Kozliuk:
> > > > > +#include <rte_eal_memory.h>
> > > >
> > > > I think we should find a better file name for these wrappers.
> > > > "EAL memory" means DPDK memory allocator in my mind.
> > > > We need a file name which is about OS-independent wrappers,
> > > > or libc wrappers.
> > > > What about rte_libc_mem.h? rte_mem_os.h? something else?
> > >
> > > See above, but anyway, "libc" is non-generic.
> >
> > Why libc is not generic?
> >
> 
> It means nothing on Windows. Also, mmap has little to do with libc.
> 
> Which file name can it be?
> 
> Your rte_mem_os.h sounds good, except internal header better be
> rte_eal_mem_os.h. Alternative: rte_eal_paging.h.

I don't think we need to use the prefix "eal" if we already have "rte_mem".
I have no strong opinion.
rte_eal_paging looks also good.
Anyway, it is internal, so we could change it if needed.
Please choose one :)






More information about the dev mailing list