[dpdk-dev] [PATCH v8 10/11] eal/windows: initialize hugepage info

[Thomas Monjalon]

10/06/2020 16:27, Dmitry Kozlyuk:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +Windows memory allocation
> +M: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> +F: lib/librte_eal/eal_hugepages.c

Is it a typo? You mean lib/librte_eal/windows/eal_hugepages.c ?

[...]
> --- a/doc/guides/windows_gsg/build_dpdk.rst
> +++ b/doc/guides/windows_gsg/build_dpdk.rst
> -Run the helloworld example
> -==========================
> -
> -Navigate to the examples in the build directory and run `dpdk-helloworld.exe`.
> -
> -.. code-block:: console
> -
> -    cd C:\Users\me\dpdk\build\examples
> -    dpdk-helloworld.exe
> -    hello from core 1
> -    hello from core 3
> -    hello from core 0
> -    hello from core 2
> -
> -Note for MinGW-w64: applications are linked to ``libwinpthread-1.dll``
> -by default. To run the example, either add toolchain executables directory
> -to the PATH or copy the library to the working directory.
> -Alternatively, static linking may be used (mind the LGPLv2.1 license).
[...]
> --- /dev/null
> +++ b/doc/guides/windows_gsg/run_apps.rst
> +Run the ``helloworld`` Example
> +------------------------------
> +
> +Navigate to the examples in the build directory and run `dpdk-helloworld.exe`.
> +
> +.. code-block:: console
> +
> +    cd C:\Users\me\dpdk\build\examples
> +    dpdk-helloworld.exe
> +    hello from core 1
> +    hello from core 3
> +    hello from core 0
> +    hello from core 2
> +
> +Note for MinGW-w64: applications are linked to ``libwinpthread-1.dll``
> +by default. To run the example, either add toolchain executables directory
> +to the PATH or copy the library to the working directory.
> +Alternatively, static linking may be used (mind the LGPLv2.1 license).

I tend thinking that such move is better understood
in a separate prior patch.