[dpdk-dev] [PATCH v5 3/8] pci: build on Windows

Thomas Monjalon thomas at monjalon.net
Tue Jun 16 10:22:34 CEST 2020


09/06/2020 12:31, talshn at mellanox.com:
> From: Tal Shnaiderman <talshn at mellanox.com>
> 
> Added <sys/types.h> in Windows header file includes
> to include off_t type since it is needed by PCI.

Why is it added in rte_os.h and not in the file using off_t?


> export per_lcore__rte_errno from eal since it is needed by PCI.
[...]
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -386,6 +386,9 @@ EXPERIMENTAL {
> +	# added in 20.08
> +	__emutls_v.per_lcore__rte_errno;

I think it is not needed.




More information about the dev mailing list