[dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

Thomas Monjalon thomas at monjalon.net
Tue Jun 16 18:12:30 CEST 2020


05/06/2020 20:35, Stephen Hemminger:
> On Thu,  4 Jun 2020 10:17:31 -0700
> Stephen Hemminger <stephen at networkplumber.org> wrote:
> 
> > The code in rte_cuckoo_hash multi-writer support is broken if write
> > operations are called from a non-EAL thread.
> > 
> > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL
> > thread and that leads to using wrong local cache.
> > 
> > Add error checks and document the restriction.
> > 
> > Fixes: 9d033dac7d7c ("hash: support no free on delete")
> > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention")
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > Cc: honnappa.nagarahalli at arm.com
> > Cc: pablo.de.lara.guarch at intel.com
> 
> This restriction also needs to be added to the known issues
> section of EAL

Are you going to send a v2 adding doc?




More information about the dev mailing list