[dpdk-dev] [PATCH 02/21] net/ixgbe/base: change in the condition for response HI

[Ferruh Yigit]

On 6/12/2020 4:23 AM, Guinan Sun wrote:
> According to SGVL EAS Host interface Shadow RAM Read (0x31)
> command response buffer length is stored in two bytes,
> instead of one byte.

For patch subject, better to say 'fix' instead of 'change' because that is what
done.
Previously Shadow RAM Read (0x31) command response buffer length was taken
wrong, now you are fixing it. Overall "Shadow RAM Read (0x31)" command response
value was wrong, so I guess it can be fair to say:
"net/ixgbe/base: fix host interface shadow RAM read"

> 
> Signed-off-by: Mateusz Kowalski <mateusz.kowalski at intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun at intel.com>
> ---
>  drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
> index 36c003844..9e3b71e38 100644
> --- a/drivers/net/ixgbe/base/ixgbe_common.c
> +++ b/drivers/net/ixgbe/base/ixgbe_common.c
> @@ -4656,7 +4656,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer,
>  	 * Read Flash command requires reading buffer length from
>  	 * two byes instead of one byte
>  	 */
> -	if (resp->cmd == 0x30) {
> +	if (resp->cmd == 0x30 || resp->cmd == 0x31) {
>  		for (; bi < dword_len + 2; bi++) {
>  			buffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG,
>  							  bi);
>