[dpdk-dev] [PATCH 19/21] net/ixgbe/base: remove default advertising for 2.5G and 5G

[Ferruh Yigit]

On 6/12/2020 4:24 AM, Guinan Sun wrote:
> We are seeing interoperability issues with switches when 2.5G and 5G are
> advertised by default, so default to off.

This is only for 'X550' device, right? If so can you please clarify this in the
patch title and the commit log?

> 
> LINUX ONLY:
> 
> We will need to add a note to our README on how to enable 2.5G and 5G.
> The netwmask is a combination of:
> 
> 0x020	1000baseT Full
> 0x800000000000	2500baseT Full
> 0x1000000000000	5000baseT Full
> 0x1000	10000baseT Full
> 
> Combine the two into the advertisement flags:
> ethtool -s advertise ethX <mask value>

I can see this is Linux only so we can drop from commit log, but do we need to
document something similar for DPDK?

> 
> Signed-off-by: Todd Fujinaka <todd.fujinaka at intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun at intel.com>
> ---
>  drivers/net/ixgbe/base/ixgbe_phy.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c
> index f859b152e..8d4d9bbfe 100644
> --- a/drivers/net/ixgbe/base/ixgbe_phy.c
> +++ b/drivers/net/ixgbe/base/ixgbe_phy.c
> @@ -915,10 +915,6 @@ static s32 ixgbe_get_copper_speeds_supported(struct ixgbe_hw *hw)
>  		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_100_FULL;
>  
>  	switch (hw->mac.type) {
> -	case ixgbe_mac_X550:
> -		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
> -		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
> -		break;
>  	case ixgbe_mac_X550EM_x:
>  	case ixgbe_mac_X550EM_a:
>  		hw->phy.speeds_supported &= ~IXGBE_LINK_SPEED_100_FULL;
>