[dpdk-dev] [PATCH v2 2/6] security: add support for DOCSIS protocol

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Coyle, David <david.coyle at intel.com>
> Sent: Tuesday, June 23, 2020 11:14 AM
> To: akhil.goyal at nxp.com; Doherty, Declan <declan.doherty at intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Trahe, Fiona
> <fiona.trahe at intel.com>; Zhang, Roy Fan <roy.fan.zhang at intel.com>;
> Ananyev, Konstantin <konstantin.ananyev at intel.com>
> Cc: dev at dpdk.org; thomas at monjalon.net; Yigit, Ferruh
> <ferruh.yigit at intel.com>; Ryan, Brendan <brendan.ryan at intel.com>;
> hemant.agrawal at nxp.com; anoobj at marvell.com; ruifeng.wang at arm.com;
> lironh at marvell.com; rnagadheeraj at marvell.com; jsrikanth at marvell.com;
> G.Singh at nxp.com; jianjay.zhou at huawei.com; ravi1.kumar at amd.com;
> Richardson, Bruce <bruce.richardson at intel.com>; olivier.matz at 6wind.com;
> honnappa.nagarahalli at arm.com; stephen at networkplumber.org;
> alexr at mellanox.com; jerinj at marvell.com; Coyle, David
> <david.coyle at intel.com>; O'loingsigh, Mairtin <mairtin.oloingsigh at intel.com>
> Subject: [PATCH v2 2/6] security: add support for DOCSIS protocol
> 
> Add support for DOCSIS protocol to rte_security library. This support currently
> comprises the combination of Crypto and CRC operations.
> 
> A security operation definition is also added. This allow security protocol related
> parameters be specified at the operation level. For DOCSIS, these parameters
> include CRC length and offset. The security operation is accessed via a crypto
> operation.
> 
> Signed-off-by: David Coyle <david.coyle at intel.com>
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh at intel.com>

...

> +++ b/lib/librte_security/rte_security.h
> @@ -293,6 +293,30 @@ struct rte_security_pdcp_xform {
>  	uint32_t hfn_ovrd;
>  };
> 
> +/** DOCSIS direction */
> +enum rte_security_docsis_direction {
> +	RTE_SECURITY_DOCSIS_UPLINK,
> +	/**< Uplink
> +	 * - Decryption, followed by CRC Verification
> +	 */
> +	RTE_SECURITY_DOCSIS_DOWNLINK,
> +	/**< Downlink
> +	 * - CRC Generation, followed by Encryption
> +	 */
> +};
> +
> +/**
> + * DOCSIS security session configuration.
> + *
> + * This structure contains data required to create a DOCSIS security session.
> + */
> +struct rte_security_docsis_xform {
> +	enum rte_security_docsis_direction direction;
> +	/** DOCSIS direction */

Missing "<" here.