[dpdk-dev] [PATCH v2 5/6] test/crypto: add DOCSIS security test cases

[De Lara Guarch, Pablo]

Hi David,

> -----Original Message-----
> From: Coyle, David <david.coyle at intel.com>
> Sent: Tuesday, June 23, 2020 11:14 AM
> To: akhil.goyal at nxp.com; Doherty, Declan <declan.doherty at intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Trahe, Fiona
> <fiona.trahe at intel.com>; Zhang, Roy Fan <roy.fan.zhang at intel.com>;
> Ananyev, Konstantin <konstantin.ananyev at intel.com>
> Cc: dev at dpdk.org; thomas at monjalon.net; Yigit, Ferruh
> <ferruh.yigit at intel.com>; Ryan, Brendan <brendan.ryan at intel.com>;
> hemant.agrawal at nxp.com; anoobj at marvell.com; ruifeng.wang at arm.com;
> lironh at marvell.com; rnagadheeraj at marvell.com; jsrikanth at marvell.com;
> G.Singh at nxp.com; jianjay.zhou at huawei.com; ravi1.kumar at amd.com;
> Richardson, Bruce <bruce.richardson at intel.com>; olivier.matz at 6wind.com;
> honnappa.nagarahalli at arm.com; stephen at networkplumber.org;
> alexr at mellanox.com; jerinj at marvell.com; Coyle, David
> <david.coyle at intel.com>; O'loingsigh, Mairtin <mairtin.oloingsigh at intel.com>
> Subject: [PATCH v2 5/6] test/crypto: add DOCSIS security test cases
> 
> Add uplink and downlink DOCSIS unit test cases and vectors, to test
> the combined DOCSIS Crypto-CRC support that has been added to the
> rte_security and rte_cryptodev libraries.
> 
> Signed-off-by: David Coyle <david.coyle at intel.com>
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh at intel.com>

...

> +static int
> +test_docsis_proto_uplink(int i, struct docsis_test_data *d_td)
> +{
> +	struct rte_security_op *sec_op;
> +	struct rte_security_docsis_op *doc_op;
> +	struct crypto_testsuite_params *ts_params = &testsuite_params;
> +	struct crypto_unittest_params *ut_params = &unittest_params;
> +	uint8_t *plaintext, *ciphertext;
> +	uint8_t *iv_ptr;
> +	int cipher_len = 0;
> +	int crc_len = 0, crc_data_len;

Minor comment. These "int" should be "unsigned int", as they are not going to hold a negative value.

> +	int ret = TEST_SUCCESS;