[dpdk-dev] [PATCH v2 02/14] bus/fslmc: fix null pointer dereference
Maxime Coquelin
maxime.coquelin at redhat.com
Wed Jun 24 14:26:46 CEST 2020
This patches fixes a null pointer derefencing that happens
when the device string passed to the iterator is NULL. This
situation can happen when iterating on a class type.
For example:
RTE_DEV_FOREACH(dev, "class=eth", &dev_iter) {
...
}
Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
Cc: stable at dpdk.org
Cc: shreyansh.jain at nxp.com
Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
drivers/bus/fslmc/fslmc_bus.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index afbd82e8db..75c15d6b67 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -603,6 +603,11 @@ fslmc_bus_dev_iterate(const void *start, const char *str,
struct rte_dpaa2_device *dev;
char *dup, *dev_name = NULL;
+ if (str == NULL) {
+ DPAA2_BUS_DEBUG("No device string\n");
+ return NULL;
+ }
+
/* Expectation is that device would be name=device_name */
if (strncmp(str, "name=", 5) != 0) {
DPAA2_BUS_DEBUG("Invalid device string (%s)\n", str);
--
2.26.2
More information about the dev
mailing list