[dpdk-dev] [PATCH v2 1/2] telemetry: support array values in data objects

Bruce Richardson bruce.richardson at intel.com
Wed Jun 24 17:09:42 CEST 2020


On Wed, Jun 24, 2020 at 02:48:23PM +0100, Ciara Power wrote:
> Arrays and Dicts now support uint64_t, int and string
> array values. Only one level of recursion supported.
> 
> Signed-off-by: Ciara Power <ciara.power at intel.com>
> 
> ---
Approach seems good to me, but I think you need more detail in the commit
log for this. I think the first sentence needs to make it clearer that its
arrays of uint64_t and arrays of int which can be supported as well as
arrays of strings. I also think some discussion of why this is necessary is
needed in the commit log as well as an explanation of how the memory alloc
and free for the array objects work.

/Bruce


More information about the dev mailing list