[dpdk-dev] [PATCH 20.08 9/9] config/arm: support python3 only

Harman Kalra hkalra at marvell.com
Thu Jun 25 11:34:37 CEST 2020


On Mon, May 25, 2020 at 10:53:28AM +0100, Bruce Richardson wrote:
> On Sat, May 23, 2020 at 11:27:42PM +0200, Thomas Monjalon wrote:
> > 22/05/2020 16:10, Kilheeney, Louise:
> > > From: Thomas Monjalon <thomas at monjalon.net> 
> > > > 22/05/2020 15:23, Louise Kilheeney:
> > > > > Changed script to explicitly use python3 only.
> > > > 
> > > > What is the reason of this change?
> > > 
> > > since python 2 is EOL, Making these scripts to use python3-only,
> > > it's part of a general update to have everything use python3.
> > > This is already using python 3 and this makes it explicit.
> > 
> > This is to avoid maintaining python 2 compatibility I guess.
> > Please insert this real reason in the git commit log.
> > 
> Also, python 2 may not be installed (unless explicitly requested) on 
> modern distro releases. My Ubuntu 20.04 still only had a "python3" binary,
> no "python" binary.
> 
> > 
> > > > --- a/config/arm/armv8_machine.py
> > > > +++ b/config/arm/armv8_machine.py
> > > > @@ -1,4 +1,4 @@
> > > > -#!/usr/bin/python
> > > > +#!/usr/bin/python3
> > 
> > Are you sure all OS have /usr/bin/python3?
> > Is it called "python" sometimes?
> > Is it always located in /usr/bin/?
> > Shouldn't we use "#! /usr/bin/env python3" ?
> > 
> Good catch.
> +1 for this. On BSD python is in /usr/local/bin

Tested config/arm/armv8_machine.py on an arm64 platform, it works fine.
+1 for the patch with changes recomended by Thomas.

Tested-by: Harman Kalra <hkalra at marvell.com>



More information about the dev mailing list