[dpdk-dev] [PATCH v2 1/3] examples/vm_power_manager: Make branch ratio threshold per core
Hunt, David
david.hunt at intel.com
Thu Jun 25 12:14:39 CEST 2020
Hi Rory,
On 18/5/2020 11:39 AM, Sexton, Rory wrote:
> This modification allows for the branch ratio threshold to be set
> per core rather than system wide. This gives greater flexibility to
> the branch ration monitoring allowing it to manage different
> workloads with different characteristics on the same system.
>
> Signed-off-by: Rory Sexton <rory.sexton at intel.com>
> ---
> examples/vm_power_manager/main.c | 40 +++++++++++---------
> examples/vm_power_manager/oob_monitor_x86.c | 2 +-
> examples/vm_power_manager/parse.c | 42 ++++++++++++++++++++-
> examples/vm_power_manager/parse.h | 3 ++
> examples/vm_power_manager/power_manager.c | 2 +-
> examples/vm_power_manager/power_manager.h | 2 +-
> 6 files changed, 68 insertions(+), 23 deletions(-)
This change is a good enhancement, as there are usually different types
of workload running on the cores in a system, each requiring a different
ratio.
Also, it's good that multiple groups of cores can be specified by using
the parameter multiple times, e.g. -b 21-23:0.5 -b 24,25:0.4
LGTM.
Reviewed-by: David Hunt <david.hunt at intel.com>
More information about the dev
mailing list