[dpdk-dev] [PATCH v9 00/10] Windows bus/pci support

Narcisa Ana Maria Vasile navasile at linux.microsoft.com
Sat Jun 27 03:54:39 CEST 2020


On Wed, Jun 24, 2020 at 11:28:37AM +0300, talshn at mellanox.com wrote:
> From: Tal Shnaiderman <talshn at mellanox.com>
> 
> This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows.
> 
> ---
> v9:
> 	* Split the patch of common OS file to config and options patches (ThomasM).
> 	* Remove rte_ prefixes from new functions as they are eal internal (ThomasM).
> 	^ Move common declarations to eal_private.h.
> 	* Add get_pci_hardware_id and parse_pci_hardware_id in pci.c (DmitryK)
> 	* Fix issues in pci.c (DmitryK)
> v8:
> 	* Move internal_config to static inside eal_common_config.c and use getters for all external uses.
> 	* Fix duplicated export line (FadyB)
> 	* Fix FreeBSD missing function.
> v7:
> 	* Remove Unneeded code from MinGW mapping script (DmitryK)
> 	* Fix error flow issues in pci.c (DmitryK)
> 	* Fix Unix build errors following unity of common functions.
> 	* Move strerror to rte_strerror (DmitryK) 
> v6:
> 	* Fix duplication of exported functions for mingw by modifying the version.map in build (new commit)
> 	* Fix comments and move additional functions to eal_common_config (DavidM)
> 	* Fix cross-compilation in mingw (DmitryK)
> 	* Fix Warnings
> 	* Move off_t type to pci (ThomasM)
> v5:
> 	* Adjust mem-mapping functions to changes in latest memory management patchset.
> 	* Fix incorrect implib definition in drivers/meson.build
> v4:
> 	* Fixed various warnings and naming conventions(DmitryK).
> 	* Fixed broken mingw-64 build(DmitryK).
> 	* Improved logging(DmitryK).
> 	* Added patch to fix warnings on rte_pci_addr logging.
> 	* Fixed broken make on linux/freebsd.
> v3:
> 	* Changes in BDF and hardware ids retrieval(DmitryK).
> 	* Apply new generic MM to all pci unix callers(DmitryK).
> 	* Minor corrections in pci.c(DmitryK).
> v2:
> 	* fix style issues.
> 	* fix error handing flow in pci.c
> 	* change eal_config.c to eal_common_config.c
> ---
Compiled successfully with clang 9.0.0.
2 warnings are generated, suggesting using safer versions of getenv() and strncpy().  
Do we have any test application to test with? dpdk-helloworld runs successfully.


More information about the dev mailing list