[dpdk-dev] [PATCH 11/16] net/dpaa: enable Tx queue taildrop

[David Marchand]

On Tue, Mar 3, 2020 at 5:59 PM Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>
> On 3/2/2020 2:58 PM, Hemant Agrawal wrote:
> > From: Gagandeep Singh <g.singh at nxp.com>
> >
> > Enable congestion handling/tail drop for TX queues.
> >
> > Signed-off-by: Gagandeep Singh <g.singh at nxp.com>
>
> I don't know why it revealed itself with this patch, but I am getting an error
> with this patch [1], this looks like build dependency error.
>
> While trying to link 'librte_pmd_dpaa_event.so', the dependent library
> 'librte_pmd_dpaa_sec.so' is not ready yet.
>
> A dependency directive is fixing it [2], at least in my environment, but it may
> need to be backported to old releases too.
>
> Would you mind sending a patch to fix the issue?
> I suggest merging it before this patchset.
>
>
> [1]
> /usr/bin/ld: cannot find -lrte_pmd_dpaa_sec
> collect2: error: ld returned 1 exit status
> make[9]: *** [.../mk/rte.lib.mk:100: librte_pmd_dpaa_event.so.20.0.2] Error 1

Looks like what I had reported earlier.
http://inbox.dpdk.org/dev/CAJFAV8yQThD3JE8n8zxM8xiH=Rp3yomhzjH0p_8uzzXdiveuxA@mail.gmail.com/


>
>
> [2]
>  diff --git a/drivers/Makefile b/drivers/Makefile
>  index 46374ca69..c70bdf9cc 100644
>  --- a/drivers/Makefile
>  +++ b/drivers/Makefile
>  @@ -21,7 +21,7 @@ DEPDIRS-compress := bus mempool
>   DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += vdpa
>   DEPDIRS-vdpa := common bus mempool
>   DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
>  -DEPDIRS-event := common bus mempool net
>  +DEPDIRS-event := common bus mempool net crypto
>   DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw
>   DEPDIRS-raw := common bus mempool net event
>

lgtm.
Thanks.


-- 
David Marchand