[dpdk-dev] [PATCH v2 1/2] net/memif: enable loopback

[Ferruh Yigit]

On 3/9/2020 10:46 AM, Július Milan wrote:
> With this patch it is possible to connect 2 DPDK memifs into loopback,
> i.e. when they have the same id and different roles, as for example:
>   "--vdev=net_memif0,role=master,id=0"
>   "--vdev=net_memif1,role=slave,id=0"
> 
> Signed-off-by: Július Milan <jmilan.dev at gmail.com>

<...>

> @@ -642,8 +645,12 @@ memif_msg_receive(struct memif_control_channel *cc)
>  
>  	size = recvmsg(cc->intr_handle.fd, &mh, 0);
>  	if (size != sizeof(memif_msg_t)) {
> -		MIF_LOG(DEBUG, "Invalid message size.");
> -		memif_msg_enq_disconnect(cc, "Invalid message size", 0);
> +		MIF_LOG(DEBUG, "Invalid message size = %zu", size);
I can see format specifier is the only diff in v2 [1], but since 'size' can be
negative (ssize_t size), shouldn't it be '%zd'?


[1]
It is good to put a changelog into the commit log, after '---' below the
sign-off, to document what has been changed in versions.