[dpdk-dev] [PATCH RFC v1 7/7] net/ena: remove duplicate memset

Gavin Hu gavin.hu at arm.com
Fri Mar 13 10:18:35 CET 2020


There is a memset operation for the whole structure so no need
to memset the sub fields in it.

Fixes: 1173fca25af9 ("ena: add polling-mode driver")
Cc: stable at dpdk.org

Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
Signed-off-by: Gavin Hu <gavin.hu at arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
---
 drivers/net/ena/ena_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 8b566aecd..ab28cfc42 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2280,8 +2280,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
 
 		/* Prepare TX context */
 		memset(&ena_tx_ctx, 0x0, sizeof(struct ena_com_tx_ctx));
-		memset(&ena_tx_ctx.ena_meta, 0x0,
-		       sizeof(struct ena_com_tx_meta));
 		ena_tx_ctx.ena_bufs = ebuf;
 		ena_tx_ctx.req_id = req_id;
 
-- 
2.17.1



More information about the dev mailing list