[dpdk-dev] [PATCH v2] net/ixgbe: fix issue for e-tag defination

Wei Zhao wei.zhao1 at intel.com
Mon Mar 30 08:33:23 CEST 2020


An issue has been caused after change definations of bool,
we had better use uint16_t to define e-tag ethertype, not 8
bits length bool, that patch will change bool bits length, which
introduce a bug for etag/etag_strip for x550 NIC. So change
to the 16 bits defination.

Cc: stable at dpdk.org
Fixes: ad43b7bce95b ("net/ixgbe: avoid multiple definitions of bool")

Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>

v2:
-add more info and find root cause for this issue
---
 drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h
index e1cd8fd16..c5d0e0912 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.h
+++ b/drivers/net/ixgbe/ixgbe_ethdev.h
@@ -358,7 +358,7 @@ struct ixgbe_l2_tn_info {
 	struct rte_hash                    *hash_handle;
 	bool e_tag_en; /* e-tag enabled */
 	bool e_tag_fwd_en; /* e-tag based forwarding enabled */
-	bool e_tag_ether_type; /* ether type for e-tag */
+	uint16_t e_tag_ether_type; /* ether type for e-tag */
 };
 
 struct rte_flow {
-- 
2.19.1



More information about the dev mailing list